0

Improvement for ZK Bind

asked 2015-04-17 14:31:31 +0800

aruille31 gravatar image aruille31
1

I wish to propose an improvement to ZK Bind framework.

When you use a view model that is managed by Spring (not the ZK factory) in some cases the org.zkoss.bind.BindComposer does not work because Spring generate a proxy for your view model bean (ex : if you have an @Aspect to the view model etc...).

ex :

@Component("myvm") @Scope("prototype") public class MyViewModel { ... }

<?variable-resolver class="org.zkoss.zkplus.spring.DelegatingVariableResolver"?> <zk> <window apply="org.zkoss.bind.BindComposer" viewModel="@id('vm')@init(myvm)" validationMessages="@id('vmsgs')" width="600px" vflex="1"> .. </zk>

That why I patched the ZK Bind 7.0.4 for it work in all cases. How can I send you the patch ?

Regards,

Antoine Ruillé

delete flag offensive retag edit

4 Replies

Sort by » oldest newest

answered 2015-04-20 09:16:47 +0800

vincentjian gravatar image vincentjian
2245 6

You can send pull request to github: https://github.com/zkoss/zk. ZK team will further check the improvement.

link publish delete flag offensive edit

answered 2015-04-22 10:04:37 +0800

aruille31 gravatar image aruille31
1

Hi Vincent,

I have no permission to push my improvement (git-receive-pack not permitted)

How can i do ?

link publish delete flag offensive edit

answered 2015-04-22 10:24:33 +0800

vincentjian gravatar image vincentjian
2245 6

You can't push directly, you should send pull request. Refer to https://help.github.com/articles/using-pull-requests/

link publish delete flag offensive edit

answered 2015-04-23 09:40:34 +0800

aruille31 gravatar image aruille31
1

Hi Vincent,

thank you for your documentation. Pull request created My fork : https:// github.com/aruille31/zk

Best regards,

Antoine

link publish delete flag offensive edit
Your reply
Please start posting your answer anonymously - your answer will be saved within the current session and published after you log in or create a new account. Please try to give a substantial answer, for discussions, please use comments and please do remember to vote (after you log in)!

[hide preview]

Question tools

Follow
1 follower

RSS

Stats

Asked: 2015-04-17 14:31:31 +0800

Seen: 32 times

Last updated: Apr 23 '15

Support Options
  • Email Support
  • Training
  • Consulting
  • Outsourcing
Learn More