Listbox bug between 6.0.0 and 6.5.2

answered 2013-07-15 06:00:16 +0800

dsised
1 ● 1

I think an uppdate was done to binder.loadComponent

I Include a zul file like this

<include id="includeSaisieActivite" src="/_missions/SaisieActivite.zul"/>

Here is the SaisieActivite.zul :

<?page title="new page title" contentType="text/html;charset=UTF-8"?>
<?meta http-equiv="X-UA-Compatible" content="chrome=1"?>
<zk>
    <window id="zoneSaisieActivite" mode="modal" position="center"
        visible="@{gestionMissions.actionActivite.enCours}" width="400px"
        title="@{gestionMissions.actionActivite}">

        <grid>
            <columns>
                <column label="" />
                <column label="" />
            </columns>
            <rows>
                <row>
                    <label value="Activite"></label>
                    <combobox mold="rounded" 
                        id="saisiComboActivites"
                        model="@{gestionMissions.listeActivite}"
                        selectedItem="@{gestionMissions.missionActiviteCourant.theActivite, save-when='validerMissionActivite.onClick'}"
                        readonly="true" 
                        disabled="@{gestionMissions.actionActivite.suppression}"
                        constraint="no empty">

                        <comboitem self="@{each=activite}"
                            label="@{activite.nom}" />

                    </combobox>

                </row>
                <row>
                    <label value="Principale" />
                    <checkbox
                        checked="@{gestionMissions.missionActiviteCourant.principale, save-when='validerMissionActivite.onClick'}"
                        value="Principale" disabled="@{gestionMissions.actionActivite.suppression}" />
                </row>

            </rows>
        </grid>



        <div align="center">
            <button id="validerMissionActivite" label="Valider" />
            <button id="annulerMissionActivite" label="Annuler" />
        </div>
    </window>
</zk>

As you can see, I use "@{gestionMissions.actionActivite.enCours}" to set the include visible.

In my model I have this code :

@Listen("onClick = #includeSaisieActivite #zoneSaisieActivite #validerMissionActivite")
public void onClick$validerMissionActivite() {
    setActionActivite(Action.AUCUNE);
    binder.loadComponent(zoneSaisieActivite);
}

So,

• I change my Actionactivite to "Action.Aucune
• I ask to zoneSaisieActivite to be reloaded by the binder

The error message is coming with the call of

binder.loadComponent(zoneSaisieActivite);

It's working very fine with ZK 6.0.0 but it crashes with ZK 6.5.2. I think a change has been done to ZK element. Something like "The window become unvisible so some list are not loaded : in my case, the combobox is empty...

To give you more information :

• if I change for testing like this (I don't use the binder) I have no error :

  @Listen("onClick = #includeSaisieActivite #zoneSaisieActivite #validerMissionActivite") public void onClick$validerMissionActivite() { setActionActivite(Action.AUCUNE); //binder.loadComponent(zoneSaisieActivite); zoneSaisieActivite.setVisible(false); }

• if I change for testing like this (I don't use the binder) it crashes:

  @Listen("onClick = #includeSaisieActivite #zoneSaisieActivite #validerMissionActivite") public void onClick$validerMissionActivite() { binder.loadComponent(zoneSaisieActivite); }

So, What mmust I do to let binder.loadComponent(zoneSaisieActivite) working ?

Thank you

answered 2013-07-16 00:03:40 +0800

dsised
1 ● 1

I done an other test:

If I remove "save-when" in my combobox, The error doesn't appear but I have a bad visual effect on my application (the value is visually changed while I have no clicked on my validate button).

Do you have enougth information to reprocuce the error ?

Thank you.

PS: I'll try to do a little sample ZUL with the error

answered 2013-07-16 03:58:03 +0800

dsised
1 ● 1

Here is a working sample to reproduce the bug: Select one line in the list box; Change the language in the combo box and then click OK

As is : - it's working fine with ZK 6.0.0 - it bugs with ZK 6.5.2

If you remove "save-when" in the combo box, there is no bug but the functionality is not good because it has changes my value ils the list box while I have no clicked on OK button.

TestModel.java :

/**
 * 
 */
package nc.mairie.temp;

import java.util.ArrayList;

import org.zkoss.zk.ui.Component;
import org.zkoss.zk.ui.select.SelectorComposer;
import org.zkoss.zk.ui.select.annotation.Listen;
import org.zkoss.zk.ui.select.annotation.Wire;
import org.zkoss.zkplus.databind.AnnotateDataBinder;
import org.zkoss.zul.Div;


/**
 * @author boulu72
 *
 */
public class TestModel extends SelectorComposer<Component> {

    /**
     * 
     */
    private static final long serialVersionUID = -8608406922690897596L;

    AnnotateDataBinder binder;

    ArrayList<Word> listWord;

    public ArrayList<Word> getListWord() {
        return listWord;
    }

    ArrayList <Lang> listLang = new ArrayList<>();

    public ArrayList<Lang> getListLang () {
        return listLang;
    }


    public class Lang {
        String name;
        String language;

        Lang(String name, String language) {
            this.name = name;
            this.language = language;
        }

        public String getName() {
            return name;
        }
        public void setName(String name) {
            this.name = name;
        }
        public String getLanguage() {
            return language;
        }
        public void setLanguage(String language) {
            this.language = language;
        }

    }


    Word currentWord;

    public class Word {
        String word;
        Lang lang;

        Word(String word, Lang lang) {
            this.word = word;
            this.lang = lang;
        }

        public String getWord() {
            return word;
        }

        public void setWord(String word) {
            this.word = word;
        }

        public Lang getLang() {
            return lang;
        }

        public void setLang(Lang lang) {
            this.lang=lang;
        }

        public String getFullName () {
            return getWord() + " "+ getLang().getLanguage();
        }


    }

    boolean visible = false;

    public Word getCurrentWord(){
        return currentWord;
    }

    public void setCurrentWord(Word word){
        this.currentWord= word;
    }

    public boolean isVisible() {
        return visible;
    }


    @Wire
    Div detailWord;

    @Override
    public void doAfterCompose(Component comp) throws Exception {
        super.doAfterCompose(comp);

        Lang l1 = new Lang("eng","ENGLISH");
        Lang l2 = new Lang("fr","FRANCAIS");

        listLang.add(l1);
        listLang.add(l2);

        Word p1 = new Word("Hello", listLang.get(0));
        Word p2 = new Word("Coucou", listLang.get(1));

        listWord = new ArrayList<Word>();
        listWord.add(p1);
        listWord.add(p2);

        comp.setAttribute(comp.getId(), this, true);

        binder = new AnnotateDataBinder(comp);
        binder.loadAll();

    }

    @Listen("onClick = #listBoxWord;")
    public void onClick$listBoxWord() {
        visible = true;
        binder.loadComponent(detailWord);
    }

    @Listen("onClick = #btnOk;")
    public void onClick$btnOk() {
        visible = false;
        binder.loadComponent(detailWord);
    }

}

Test.zul:

<?page title="new page title" contentType="text/html;charset=UTF-8"?>
<?meta http-equiv="X-UA-Compatible" content="chrome=1"?>
<zk>

    <window id="test" apply="nc.mairie.temp.TestModel">


        <div id="windowListWord">
            <listbox id="listBoxWord" model="@{test.listWord}"
                selectedItem="@{test.currentWord}" width="500px">
                <listhead>
                    <listheader label="word" />
                    <listheader label="lang" />
                    <listheader label="fullName" />
                </listhead>
                <listitem self="@{each=word}">
                    <listcell label="@{word.word}" />
                    <listcell label="@{word.lang.language}" />
                    <listcell label="@{word.fullName}" />
                </listitem>
            </listbox>
        </div>

    <div id="detailWord"  visible="@{test.visible}">
        <grid width="400px">
            <rows>
                <row>
                    First Name:
                    <textbox id="firstName"
                        value="@{test.currentWord.word}" />
                </row>

                <row>
                    Lang:
                        <combobox mold="rounded" 
                        model="@{test.listLang}"
                        selectedItem="@{test.currentWord.lang, save-when='btnOk.onClick'}">
                        <comboitem self="@{each=lang}"
                            label="@{lang.language}" />
                        </combobox>


                </row>
                <row>

                    Full Name:
                    <label id="fullName"
                        value="@{test.currentWord.fullName}" />
                </row>
                <row>
                <button id="btnOk" label="Ok" />
                </row>
            </rows>
        </grid>
    </div>

    </window>
</zk>