Method saves old value of AtomicBoolean outside of synchroization block:
Tags
People
Badges
Help
public Desktop getDesktopIfAny(String desktopId) {
final boolean old = _desktops.disableExpunge(true);
try {
synchronized (_desktops) {
return _desktops.get(desktopId);
}
} finally {
_desktops.disableExpunge(old);
}
}
This may cause condition raise and old value become true. This will cause that dasktop cache never expunged.
The boolean declaration used to be inside of the synchronized block until ZK 7.0.6, and was moved out at that point. This is an intentional change, not a side effect of another change.
Most likely, the previous implementation was causing a dead-lock in serialization / deserialization.
Did you encounter a case desktop cache would fail to expunge (is this a live problem)? or did you see this from review at the moment?
This could be a minor memory leak, potentially. By default, the SessionDesktopCacheProvider will store the desktop cache as a session property. If the cache for a specific user no longer expunge, it will still be destroyed when the session is destroyed.
Trouble is save an old value that can be true (expungr disabled). In finally block code may restore true value, than expunge never happens. As example to reproduce create the iframe on a page. Posiible fix: if (!old) desableExpunge(old) to prevent enabling expunge if someone else disabled expunge
nsaazn ( 2022-07-20 20:54:04 +0800 )editAsked: 2022-07-18 20:18:51 +0800
Seen: 9 times
Last updated: Jul 20 '22
